misc: puppeteer script to test a page from devtools

lighthouse-core/scripts/pptr-run-devtools.js

@@ -34,20 +34,23 @@ function addSniffer(receiver, methodName, override) {
     throw new Error('Cannot find method to override: ' + methodName);
   }
 
-  receiver[methodName] = function() {
+  /**
+   * @param  {...any} args
+   */
+  receiver[methodName] = function(...args) {
     let result;
     try {
       // eslint-disable-next-line prefer-rest-params
-      result = original.apply(this, arguments);
+      result = original.apply(this, args);
     } finally {
       receiver[methodName] = original;
     }
     // In case of exception the override won't be called.
     try {
       // eslint-disable-next-line prefer-rest-params
-      Array.prototype.push.call(arguments, result);
+      Array.prototype.push.call(args, result);
       // eslint-disable-next-line prefer-rest-params
-      override.apply(this, arguments);
+      override.apply(this, args);
     } catch (e) {
       throw new Error('Exception in overriden method \'' + methodName + '\': ' + e);
     }
@@ -129,12 +132,14 @@ async function readUrlList() {
   /** @type {string[]} */
   const urlList = [];
   const rl = readline.createInterface(process.stdin, process.stdout);
-  rl.on('line', line => {
-    if (line.startsWith('#')) return;
+
+  // @ts-ignore Iterable in Node 12
+  for await (const line of rl) {
+    if (line.startsWith('#')) continue;
     urlList.push(line);
-  });
+  }
 
-  return new Promise(resolve => rl.on('close', () => resolve(urlList)));
+  return urlList;
 }
 
 async function run() {