-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: gzip treemap data #12519
Merged
Merged
report: gzip treemap data #12519
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
d5123ca
report: encode data even if very large
connorjclark 267d578
ok
connorjclark d7281c0
rm
connorjclark ff0bfd1
no btoa lol
connorjclark c417fcb
benchmark
connorjclark 8ac3a39
lol
connorjclark 720c427
test
connorjclark f0e8949
pako
connorjclark 6d6e453
fixtest
connorjclark ef3e69e
test
connorjclark c9c60df
minify
connorjclark 585bfa0
Merge remote-tracking branch 'origin/master' into treemap-encode
connorjclark a638270
tweak
connorjclark 9eb78f6
dont use minified
connorjclark d985f61
gzip optional
connorjclark 13a4671
upgrade puppeteer for compression stream
connorjclark 07e3c8d
revert puppeteer upgrade
connorjclark ea226a6
Merge remote-tracking branch 'origin/master' into treemap-encode
connorjclark 5365e53
update
connorjclark a6ff9bb
yay
connorjclark b473636
pr
connorjclark 50ff2f1
names
connorjclark ca16fff
deprecate postmessage
connorjclark 5b2f7d3
rename
connorjclark b8e6b84
tweak
connorjclark c6dafbd
pr
connorjclark 56a55e0
rename
connorjclark 363022e
comment
connorjclark e33568a
rename
connorjclark 941cadb
tweak
connorjclark d55f819
Update types/html-renderer.d.ts
connorjclark b8d8aff
edit
connorjclark f757094
f0a38c0
Merge remote-tracking branch 'origin/master' into treemap-encode
connorjclark d45dc4b
merge
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
/** | ||
* @license Copyright 2021 The Lighthouse Authors. All Rights Reserved. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
'use strict'; | ||
|
||
/* global self btoa atob window CompressionStream Response */ | ||
|
||
const btoa_ = typeof btoa !== 'undefined' ? | ||
btoa : | ||
/** @param {string} str */ | ||
(str) => Buffer.from(str).toString('base64'); | ||
const atob_ = typeof atob !== 'undefined' ? | ||
atob : | ||
/** @param {string} str */ | ||
(str) => Buffer.from(str, 'base64').toString(); | ||
|
||
/** | ||
* Takes an UTF-8 string and returns a base64 encoded string. | ||
* If gzip is true, the UTF-8 bytes are gzipped before base64'd, using | ||
* CompressionStream (currently only in Chrome), falling back to pako | ||
* (which is only used to encode in our Node tests). | ||
* @param {string} string | ||
* @param {{gzip: boolean}} options | ||
* @return {Promise<string>} | ||
*/ | ||
async function toBase64(string, options) { | ||
let bytes = new TextEncoder().encode(string); | ||
|
||
if (options.gzip) { | ||
if (typeof CompressionStream !== 'undefined') { | ||
const cs = new CompressionStream('gzip'); | ||
const writer = cs.writable.getWriter(); | ||
writer.write(bytes); | ||
writer.close(); | ||
const compAb = await new Response(cs.readable).arrayBuffer(); | ||
bytes = new Uint8Array(compAb); | ||
} else { | ||
/** @type {import('pako')=} */ | ||
const pako = window.pako; | ||
bytes = pako.gzip(string); | ||
} | ||
} | ||
|
||
let binaryString = ''; | ||
// This is ~25% faster than building the string one character at a time. | ||
// https://jsbench.me/2gkoxazvjl | ||
const chunkSize = 5000; | ||
for (let i = 0; i < bytes.length; i += chunkSize) { | ||
binaryString += String.fromCharCode(...bytes.subarray(i, i + chunkSize)); | ||
} | ||
return btoa_(binaryString); | ||
} | ||
|
||
/** | ||
* @param {string} encoded | ||
* @param {{gzip: boolean}} options | ||
* @return {string} | ||
*/ | ||
function fromBase64(encoded, options) { | ||
const binaryString = atob_(encoded); | ||
const bytes = Uint8Array.from(binaryString, c => c.charCodeAt(0)); | ||
|
||
if (options.gzip) { | ||
/** @type {import('pako')=} */ | ||
const pako = window.pako; | ||
return pako.ungzip(bytes, {to: 'string'}); | ||
} else { | ||
return new TextDecoder().decode(bytes); | ||
} | ||
} | ||
|
||
if (typeof module !== 'undefined' && module.exports) { | ||
module.exports = {toBase64, fromBase64}; | ||
} else { | ||
self.TextEncoding = {toBase64, fromBase64}; | ||
} |
41 changes: 41 additions & 0 deletions
41
lighthouse-core/test/report/html/renderer/text-encoding-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/** | ||
* @license Copyright 2021 The Lighthouse Authors. All Rights Reserved. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
'use strict'; | ||
|
||
const TextEncoding = require('../../../../report/html/renderer/text-encoding.js'); | ||
|
||
/* eslint-env jest */ | ||
|
||
describe('TextEncoding', () => { | ||
beforeAll(() => { | ||
global.window = {pako: require('pako')}; | ||
}); | ||
|
||
afterAll(() => { | ||
global.window = undefined; | ||
}); | ||
|
||
/** @type {string} */ | ||
async function test(str) { | ||
for (const gzip of [false, true]) { | ||
const binary = await TextEncoding.toBase64(str, {gzip}); | ||
const roundtrip = TextEncoding.fromBase64(binary, {gzip}); | ||
expect(roundtrip.length).toEqual(str.length); | ||
expect(roundtrip).toEqual(str); | ||
} | ||
} | ||
|
||
it('works', async () => { | ||
await test(''); | ||
await test('hello'); | ||
await test('😃'); | ||
await test('{åß∂œ∑´}'); | ||
await test('Some examples of emoji are 😃, 🧘🏻♂️, 🌍, 🍞, 🚗, 📞, 🎉, ♥️, 🍆, and 🏁.'); | ||
await test('.'.repeat(125183)); | ||
await test('😃'.repeat(125183)); | ||
await test(JSON.stringify(require('../../../../../lighthouse-treemap/app/debug.json'))); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
speaking of #12570 (comment), there used to be a thing with the closure license checker and the files in
renderer/
, which is why they all have the usual long(er) form of the Apache 2 header. Have you tried importing this yet? Or is that no longer flaggededit: or I guess it was license-header line length? Weird. But still, same question :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like something that would only show up in the CL check, which I never did (just built and manually tested). If that's the case, I'll edit in the import and just make a new PR here that can land whenever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any downside to changing it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snippet renderer has the same comment and is in BUILD, so it should be fine