Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(proto): add ConfigSettings fields #15616

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

paulirish
Copy link
Member

fixes #15193

I adapted the suggested syntax quite a bit. But... it's now happy for python, go, and C++ protobuf handling.

with the additions we can delete some of the hax in proto-processors (which is used in LR)

@paulirish paulirish requested a review from a team as a code owner November 16, 2023 20:03
@paulirish paulirish requested review from adamraine and removed request for a team November 16, 2023 20:03
@adamraine adamraine changed the title proto: add ConfigSettings fields. misc(proto): add ConfigSettings fields. Nov 16, 2023
@brendankenny
Copy link
Member

brendankenny commented Nov 16, 2023

Probably good to incentivize stability, but this means we can't change these types later (e.g. string to a struct or whatever), just retire them and pick a new name, right?

Also does it matter if e.g. auditMode/gatherMode are bool in the proto but really boolean | string? string is unusual outside of development of LH itself but it is possible depending on how the person is generating their LHRs (I'm assuming smokerider won't run into this?).

@connorjclark connorjclark changed the title misc(proto): add ConfigSettings fields. misc(proto): add ConfigSettings fields Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proto file missing fields
4 participants