core(driver): checkForQuiet bugfix to properly handle setTimeout() #16155
+30
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you describe this bug in a bit more detail? If the target page is closed then a crash seems perfectly reasonable to me. |
In my particular case, I'm not using lighthouse as a cli tool, I'm calling gotoURL() directly, so I want to handle this exception gracefully and wind down correctly. Right now - node just exits. |
|
Using |
aguidrevitch
force-pushed
the
bugfix/check-for-quiet-unhandled-rejection
branch
from
79ba5a4
to
8b3b88a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR fixes unhandled rejections which happen in setTimeout(checkForQuiet).
It is a bugfix.
When target page gets closed during waitForCPUIdle, lighthouse crashes.