fix!: allow react v17, v18 and v19 in peerDependencies and mark them as optional
#421
+36
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this please get reviewed? we've been using quicklink with react 17 and 18, no issues. |
5 tasks
|
@addyosmani could we maybe land this as a feature? The only issue AFAICT is that we don't test v16, so, perhaps, going back to the minimum support react version would be better? Not sure how to test both. |
XhmikosR
force-pushed
the
xmr/react-peer
branch
from
4f1765c to
a52cee4
Compare
|
@addyosmani what should we do with this? I think the next version should be a major bump since it's so long and that would allow us to land breaking changes like this PR and #368. |
XhmikosR
changed the title
peerDependencies and mark them as optional
XhmikosR
force-pushed
the
xmr/react-peer
branch
from
f6cfac4 to
9e66395
Compare
Merged
addyosmani
approved these changes
Apr 4, 2025
|
@addyosmani So, the new version will be a major version bump? That's why this is in still draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363