-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added integration test for single sharded DF job #1848
Added integration test for single sharded DF job #1848
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1848 +/- ##
============================================
+ Coverage 43.99% 51.48% +7.48%
+ Complexity 3451 1273 -2178
============================================
Files 830 370 -460
Lines 49156 20126 -29030
Branches 5153 2041 -3112
============================================
- Hits 21628 10362 -11266
+ Misses 25871 9107 -16764
+ Partials 1657 657 -1000
|
e006d1b
to
837f4f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
...-spanner/src/test/java/com/google/cloud/teleport/v2/templates/DataStreamToSpannerITBase.java
Show resolved
Hide resolved
...va/com/google/cloud/teleport/v2/templates/DatastreamToSpannerSingleDFShardedMigrationIT.java
Outdated
Show resolved
Hide resolved
...va/com/google/cloud/teleport/v2/templates/DatastreamToSpannerSingleDFShardedMigrationIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR for merging sharded jobs - link
Will merge IT PR after the above PR is merged.
This is the draft PR with all changes combined and all tests passing.