Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration test for single sharded DF job #1848

Merged

Conversation

shreyakhajanchi
Copy link
Contributor

PR for merging sharded jobs - link

Will merge IT PR after the above PR is merged.

This is the draft PR with all changes combined and all tests passing.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.48%. Comparing base (7294b49) to head (fc9ac93).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1848      +/-   ##
============================================
+ Coverage     43.99%   51.48%   +7.48%     
+ Complexity     3451     1273    -2178     
============================================
  Files           830      370     -460     
  Lines         49156    20126   -29030     
  Branches       5153     2041    -3112     
============================================
- Hits          21628    10362   -11266     
+ Misses        25871     9107   -16764     
+ Partials       1657      657    -1000     
Components Coverage Δ
spanner-templates 66.16% <ø> (+2.63%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 74.80% <ø> (-0.03%) ⬇️
spanner-live-reverse-replication 75.50% <ø> (+6.95%) ⬆️
spanner-bulk-migration 84.28% <ø> (+<0.01%) ⬆️

see 505 files with indirect coverage changes

darshan-sj
darshan-sj previously approved these changes Oct 3, 2024
Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyakhajanchi shreyakhajanchi merged commit 8ab465d into GoogleCloudPlatform:main Oct 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants