Build PRs using artifact registry packages #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polber
force-pushed
the
jkinard/release-ar
branch
from
3c5c307
to
e82a9e6
Compare
Polber
force-pushed
the
jkinard/release-ar
branch
from
09a0e35
to
19ada0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1862 +/- ##
============================================
- Coverage 45.09% 45.08% -0.01%
+ Complexity 3935 3609 -326
============================================
Files 835 835
Lines 49703 49703
Branches 5232 5232
============================================
- Hits 22412 22411 -1
Misses 25625 25625
- Partials 1666 1667 +1
|
Polber
force-pushed
the
jkinard/release-ar
branch
from
19ada0c
to
581c359
Compare
Polber
changed the title
Polber
force-pushed
the
jkinard/release-ar
branch
6 times, most recently
from
e61345b
to
c379cf8
Compare
Polber
force-pushed
the
jkinard/release-ar
branch
from
c379cf8
to
9bbea6f
Compare
Polber
force-pushed
the
jkinard/release-ar
branch
from
9bbea6f
to
ccc0ae8
Compare
|
Could you add a description of what/why this is doing now that we pulled out the urgent pieces? It does also look like checks might be persistently failing (not sure if that's a flake or not) |
|
@damccorm It's also hard to test because new caches get created by other workflows which affect this one being able to use AR packages instead of maven central. Once it is merged, I'll be able to clear caches and all new ones will use AR packages. I'm pretty confident this change works, but let's wait until next week to merge so I can keep an eye on actions and see if anything fails. |
damccorm
reviewed
Oct 14, 2024
damccorm
approved these changes
Oct 15, 2024
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Signed-off-by: Jeffrey Kinard <[email protected]>
Polber
force-pushed
the
jkinard/release-ar
branch
from
ccc0ae8
to
04bc025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures maven on GitHub Actions workers (self-hosted) to pull dependencies from a Google-hosted artifact registry. This ensures that PR's are able to stage templates the same way that templates are staged during the release process to detect possible package discrepancies earlier.