Require hashes for all pip installs #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1871 +/- ##
============================================
- Coverage 44.79% 44.78% -0.01%
+ Complexity 3564 3562 -2
============================================
Files 832 832
Lines 49480 49480
Branches 5196 5196
============================================
- Hits 22165 22161 -4
- Misses 25669 25672 +3
- Partials 1646 1647 +1
|
…wTemplates into users/damccorm/requireHashes
Polber
requested changes
Oct 9, 2024
plugins/core-plugin/src/main/resources/Dockerfile-template-yaml
Outdated
Show resolved
Hide resolved
plugins/core-plugin/src/main/resources/Dockerfile-template-python
Outdated
Show resolved
Hide resolved
plugins/core-plugin/src/main/resources/Dockerfile-template-xlang
Outdated
Show resolved
Hide resolved
...es-maven-plugin/src/main/java/com/google/cloud/teleport/plugin/maven/TemplatesStageMojo.java
Show resolved
Hide resolved
Polber
approved these changes
Oct 9, 2024
|
postgressql failures are unrelated to this change, so I'm going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1912 to make our pip installs more secure. We should require hashes to make sure the underlying dependency doesn't move out from under us.