-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[SpannerToSourceDb] Reverse replication Integration test with SSL based connection #4192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
darshan-sj
wants to merge
3
commits into
GoogleCloudPlatform:main
Choose a base branch
from
darshan-sj:rr-ssl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
212 changes: 212 additions & 0 deletions
212
it/jdbc/src/main/java/org/apache/beam/it/jdbc/SSLMySQLResourceManager.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,212 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.it.jdbc; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; | ||
| import java.util.Comparator; | ||
| import java.util.stream.Stream; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.testcontainers.containers.Container.ExecResult; | ||
| import org.testcontainers.containers.MySQLContainer; | ||
| import org.testcontainers.utility.DockerImageName; | ||
|
|
||
| /** | ||
| * Custom MySQL resource manager that enables SSL and dynamically extracts the ephemeral | ||
| * certificates generated by the MySQL daemon at startup, converting them into JKS files that can be | ||
| * uploaded to GCS for the Dataflow pipeline to use. | ||
| */ | ||
| public class SSLMySQLResourceManager extends AbstractJDBCResourceManager<MySQLContainer<?>> { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(SSLMySQLResourceManager.class); | ||
| private static final String DEFAULT_MYSQL_CONTAINER_NAME = "mysql"; | ||
| private static final String DEFAULT_MYSQL_CONTAINER_TAG = "8.0.30"; | ||
|
|
||
| private final MySQLContainer<?> container; | ||
|
|
||
| private String keystorePath; | ||
| private String truststorePath; | ||
| private Path tempDir; | ||
|
|
||
| private SSLMySQLResourceManager(MySQLContainer<?> container, Builder builder) { | ||
| super(container, builder); | ||
| this.container = container; | ||
| try { | ||
| generateAndExtractJKS(); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Failed to generate and extract SSL certificates", e); | ||
| } | ||
| } | ||
|
|
||
| public static Builder builder(String testId) { | ||
| return new Builder(testId); | ||
| } | ||
|
|
||
| @Override | ||
| protected int getJDBCPort() { | ||
| return MySQLContainer.MYSQL_PORT; | ||
| } | ||
|
|
||
| @Override | ||
| public String getJDBCPrefix() { | ||
| return "mysql"; | ||
| } | ||
|
|
||
| @Override | ||
| public void cleanupAll() { | ||
| try { | ||
| super.cleanupAll(); | ||
| } finally { | ||
| if (tempDir != null && Files.exists(tempDir)) { | ||
| try (Stream<Path> walk = Files.walk(tempDir)) { | ||
| walk.sorted(Comparator.reverseOrder()).map(Path::toFile).forEach(File::delete); | ||
| LOG.info("Cleaned up temporary directory: {}", tempDir); | ||
| } catch (IOException e) { | ||
| LOG.warn("Failed to clean up temporary directory: {}", tempDir, e); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private void generateAndExtractJKS() throws IOException, InterruptedException { | ||
| String password = getPassword(); | ||
| LOG.info("Generating PKCS12 keystore inside MySQL container..."); | ||
| ExecResult result = | ||
| container.execInContainer( | ||
| "openssl", | ||
| "pkcs12", | ||
| "-export", | ||
| "-in", | ||
| "/var/lib/mysql/client-cert.pem", | ||
| "-inkey", | ||
| "/var/lib/mysql/client-key.pem", | ||
| "-out", | ||
| "/var/lib/mysql/keystore.p12", | ||
| "-name", | ||
| "mysqlclient", | ||
| "-password", | ||
| "pass:" + password); | ||
|
|
||
| if (result.getExitCode() != 0) { | ||
| throw new RuntimeException( | ||
| "Failed to generate pkcs12 inside container: " + result.getStderr()); | ||
| } | ||
|
|
||
| this.tempDir = Files.createTempDirectory("mysql-ssl-"); | ||
|
|
||
| LOG.info("Copying certificates out of container to {}", tempDir); | ||
| container.copyFileFromContainer("/var/lib/mysql/ca.pem", tempDir.resolve("ca.pem").toString()); | ||
| container.copyFileFromContainer( | ||
| "/var/lib/mysql/keystore.p12", tempDir.resolve("keystore.p12").toString()); | ||
|
|
||
| String keytool = Paths.get(System.getProperty("java.home"), "bin", "keytool").toString(); | ||
|
|
||
| // Create Truststore JKS | ||
| Path truststore = tempDir.resolve("truststore.jks"); | ||
| LOG.info("Generating truststore.jks"); | ||
| ProcessBuilder pbTrust = | ||
| new ProcessBuilder( | ||
| keytool, | ||
| "-importcert", | ||
| "-alias", | ||
| "mysqlca", | ||
| "-file", | ||
| tempDir.resolve("ca.pem").toString(), | ||
| "-keystore", | ||
| truststore.toString(), | ||
| "-storepass", | ||
| password, | ||
| "-noprompt"); | ||
| runProcess(pbTrust, "Failed to generate truststore.jks"); | ||
|
|
||
| // Convert PKCS12 to Keystore JKS | ||
| Path keystore = tempDir.resolve("keystore.jks"); | ||
| LOG.info("Generating keystore.jks"); | ||
| ProcessBuilder pbKey = | ||
| new ProcessBuilder( | ||
| keytool, | ||
| "-importkeystore", | ||
| "-srckeystore", | ||
| tempDir.resolve("keystore.p12").toString(), | ||
| "-srcstoretype", | ||
| "PKCS12", | ||
| "-srcstorepass", | ||
| password, | ||
| "-destkeystore", | ||
| keystore.toString(), | ||
| "-deststoretype", | ||
| "JKS", | ||
| "-deststorepass", | ||
| password, | ||
| "-noprompt"); | ||
| runProcess(pbKey, "Failed to generate keystore.jks"); | ||
|
|
||
| this.keystorePath = keystore.toAbsolutePath().toString(); | ||
| this.truststorePath = truststore.toAbsolutePath().toString(); | ||
| LOG.info( | ||
| "Successfully generated Keystore: {} and Truststore: {}", keystorePath, truststorePath); | ||
| } | ||
|
darshan-sj marked this conversation as resolved.
|
||
|
|
||
| private void runProcess(ProcessBuilder pb, String errorMessage) | ||
| throws IOException, InterruptedException { | ||
| pb.redirectErrorStream(true); | ||
| Process process = null; | ||
| try { | ||
| process = pb.start(); | ||
| int exitCode = process.waitFor(); | ||
| if (exitCode != 0) { | ||
| String output = | ||
| new String( | ||
| process.getInputStream().readAllBytes(), java.nio.charset.StandardCharsets.UTF_8); | ||
| throw new RuntimeException( | ||
| errorMessage + ". Exit code: " + exitCode + ", Output: " + output); | ||
| } | ||
| } finally { | ||
| if (process != null) { | ||
| process.destroy(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public String getKeystorePath() { | ||
| return keystorePath; | ||
| } | ||
|
|
||
| public String getTruststorePath() { | ||
| return truststorePath; | ||
| } | ||
|
darshan-sj marked this conversation as resolved.
|
||
|
|
||
| public static final class Builder extends AbstractJDBCResourceManager.Builder<MySQLContainer<?>> { | ||
|
|
||
| public Builder(String testId) { | ||
| super(testId, DEFAULT_MYSQL_CONTAINER_NAME, DEFAULT_MYSQL_CONTAINER_TAG); | ||
| } | ||
|
|
||
| @Override | ||
| public SSLMySQLResourceManager build() { | ||
| MySQLContainer<?> container = | ||
| new MySQLContainer<>( | ||
| DockerImageName.parse(this.containerImageName).withTag(this.containerImageTag)); | ||
| return new SSLMySQLResourceManager(container, this); | ||
| } | ||
| } | ||
| } | ||
20 changes: 20 additions & 0 deletions
20
it/jdbc/src/main/java/org/apache/beam/it/jdbc/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** Package for managing JDBC resources. */ | ||
| package org.apache.beam.it.jdbc; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.