Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Conversation

@nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Sep 16, 2019

Breaking multiple samples into individual PRs.
#108

deekshithreddyr and others added 28 commits July 10, 2019 11:59
…t checkbox. Remove the Readback on the user input
index.js Link update
@nnegrey nnegrey added the WIP label Sep 16, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@nnegrey nnegrey requested a review from frankyn September 16, 2019 22:16
@nnegrey nnegrey removed the WIP label Sep 16, 2019
@nnegrey nnegrey changed the title [DO_NOT_MERGE] Dialogflow sample Dialogflow sample Sep 16, 2019
@nnegrey
Copy link
Contributor Author

nnegrey commented Sep 16, 2019

Kokoro Error: "File google-services.json is missing. The Google Services Plugin cannot function without it."

Since Android Studio now requires it to build the app, not sure how to get around this one.

@frankyn
Copy link
Contributor

frankyn commented Sep 16, 2019

@nnegrey I might not be the right person to review this PR.

If the google-services.json is similar to a service account (I haven't taken a look). Take a look at this helper Groovy function.

task copySecretKey(type: Copy) {
File secretKey = file "$System.env.GOOGLE_APPLICATION_CREDENTIALS"
from secretKey.getParent()
include secretKey.getName()
into 'src/main/res/raw'
rename secretKey.getName(), "credential.json"
}
preBuild.dependsOn(copySecretKey)

@nnegrey nnegrey removed the request for review from frankyn September 18, 2019 16:39
@nnegrey nnegrey added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 19, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@nnegrey nnegrey merged commit 4634133 into master Sep 19, 2019
@nnegrey nnegrey deleted the dialogflow-sample branch September 19, 2019 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants