Add e2e script for creating branch with benchmark results based on experiment runs.#26
Draft
Add e2e script for creating branch with benchmark results based on experiment runs.#26
Conversation
vipnydav
reviewed
May 29, 2025
perf-benchmarking-for-releases/fio-job-files/random-read-workload.fio
Outdated
Show resolved
Hide resolved
vipnydav
reviewed
May 29, 2025
perf-benchmarking-for-releases/run-all-benchmarks-and-update-results-to-branch.sh
Outdated
Show resolved
Hide resolved
vipnydav
reviewed
May 29, 2025
perf-benchmarking-for-releases/run-all-benchmarks-and-update-results-to-branch.sh
Outdated
Show resolved
Hide resolved
vipnydav
reviewed
May 29, 2025
| CLONE_DIR="${TMP_DIR}/gcsfuse" | ||
| REPO_URL="https://github.com/GoogleCloudPlatform/gcsfuse.git" | ||
| clone_gcsfuse_repo | ||
| pushd "$CLONE_DIR" |
Member
There was a problem hiding this comment.
can't we simply use cd instead of pushd as I don't see any use of returning to current directory.
vipnydav
reviewed
May 29, 2025
| DISK_TYPE=$5 | ||
|
|
||
| # Files to read from GCS. Basenames | ||
| RANDOM_READ_RES_BASENAME="gcsfuse-random-read-workload-benchmark.json" |
Member
There was a problem hiding this comment.
We might introduce more jobs in future. So we should iterate on the job files that exist in bucket instead of hardcoding them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding e2e script for creating benchmark results and creating a new branch with updated results.
NOTE: Convert bw to only MB/sec and GB/sec
NOTE: upated nrfiles to match with existing benchmark on github.