Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagsTagKey: CRD/Mapper/Fuzzer #3943

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

justinsb
Copy link
Collaborator

@justinsb justinsb commented Mar 10, 2025

  • conductor: "Generated types and mapper for TagsTagKey"
  • conductor: "Generated CRD for TagsTagKey"
  • TagsTagKey: fuzzer

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold

Looks great. Hold because I have questions in its diff-base PR #3766

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Collaborator

yuwenma commented Mar 10, 2025

/hold cancel
/lgtm

@yuwenma
Copy link
Collaborator

yuwenma commented Mar 11, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 11, 2025
@justinsb justinsb force-pushed the resource-resourcemanager-tagkey branch from 3ce7f0f to 8a4fe7d Compare March 11, 2025 14:15
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 11, 2025
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants