Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ReturnPartialSuccess=true in GKE Hub GetFeature call to ensure partial results are returned when a region is down #3946

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yufan-su
Copy link

@yufan-su yufan-su commented Mar 10, 2025

Change description

Fixes #3968

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Collaborator

yuwenma commented Mar 11, 2025

/assign @acpana

cc @haiyanmeng
Could you share more context about this?

@yufan-su
Copy link
Author

yes added the issue in #3968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable gkehub GetFeature to return partial results when a cloud region is unreachable
3 participants