conductor: update metadata for tags

[justinsb]

No description provided.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• experiments/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yuwenma]

We don't have any beta Tags resources yet. I'm wondering why we start from v1beta1 here and change the group from resourcemanager to tags. Do you mind sharing more information?

[justinsb]

So we have them, though they aren't documented. Here they are in 1.100:

https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/v1.100.0/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_tagstagkeys.tags.cnrm.cloud.google.com.yaml

[yuwenma]

I see. I didn't realize there's such a v1beta1 resource with alpha stability level and no reference doc. Considering that its group is incorrect (at least not following the convention), it's not stable like other Beta resource, and it is not that commonly used (no reference doc ), how about we treat this as a new direct alpha resource, and use the right group resourcemanager? So we don't need to dicover the TF-based special handlings and keep it backward compatible.

[justinsb]

I'm not sure I see the upside?

[yuwenma]

The advantage is that we can fix the group name and save the TF triaging time.
If we keep the group the same, then you may have to add full test coverage for the TF-based TagsTagKey before adding the scifi controller (basically adds basic- and full- test suites in https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/pkg/test/resourcefixture/testdata/basic/tags/v1beta1/tagstagkey besides #3766)