Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conductor: allow crd-version to be specified #3956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justinsb
Copy link
Collaborator

No description provided.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this as well, but I think we are not ready to open the gate for beta resources. Mostly because LLM generated code is not guaranteed to have those signals that we used for reviewing Beta resources so this heavily relies on the reviewers' notices and reviewing a beta resource basically reviews every line of the code. This is not feasible yet considering the current test coverage and the needs for fast PR reviews. What we missed here is 1. the tool to run presubmit check against real and mock and do the comparison, 2 the full CRD checkers for different API problems, detecting reference resource and validate parent URL 3. the full scenario tests for acquire, service-generated-id, multi-updates, create/update/delete only use case.

I see you need this for beta resource migration, could you run the generate-types generate-mappers separately? Those steps do not require LLM.

@barney-s
Copy link
Collaborator

/lgtm - no harm as long as current branches metadata are interpreted as v1alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants