Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conductor: run any script #3960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Mar 11, 2025

Add the ability to run any script! on the branches.

Sometimes you just want to git reset HEAD^ --hard or make fmt or something else!

$ make build && ./bin/conductor runner --branch-repo=<REPO_PATH> --branch-conf=branches.yaml --logging-dir=./logs --command=-5 --script=script.sh

Went with -5 bc this is a bit of a footgun.

Signed-off-by: Alex Pana <[email protected]>
@acpana acpana requested review from cheftako, yuwenma and barney-s March 11, 2025 15:19
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


// executeScript runs the script located at scriptPath
func executeScript(opts *RunnerOptions, branch Branch) error {
ctx := context.TODO()
Copy link
Collaborator

@cheftako cheftako Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially for a foot gun like this you need to set up the logging.
close := setLoggingWriter(opts, branch)
defer close()

@cheftako
Copy link
Collaborator

Clearly need to fix the logging.
Other concerns

  • Its a foot gun
  • Having tested and working commands which have been through code review is safer on multiple fronts including security
  • Your examples git reset HEAD^ --hard or make fmt are great but I would rather these are common shared and supported commands. Having them as scripts discourages sharing these solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants