fix(mdcode): correct the OWL-import UNBOUND push hint for --target kc - #371
Draft
libei wants to merge 1 commit into
Draft
fix(mdcode): correct the OWL-import UNBOUND push hint for --target kc#371libei wants to merge 1 commit into
libei wants to merge 1 commit into
Conversation
GoogleCloudPlatform#367 let a purely logical model push to Knowledge Catalog, but the `owl import` hint -- and the codelab and owl_converter comment that mirror it -- still said `kcmd push` is rejected "for every --target" until each source and a deployment target are bound. That is now false for `--target kc`. Update the printed note to say `kcmd push --target kc` publishes the unbound model to Knowledge Catalog as-is, and that binding is required only to deploy a graph. Bring the codelab's reproduced output and the behavior comment onto the same wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#367let a purely logical model push to Knowledge Catalog (kcmd push --target kc), but thekcmd owl importhint printed after conversion still said:That is now false for
--target kc. This corrects the printed note and the two places that reproduce it verbatim:src/tool/commands.ts— the note printed byowl import.docs/semantic-model/codelab.md— the reproduced console output (which otherwise contradicts the same codelab's "govern the model right now with--target kc" step).tests/libts/semantic/owl_converter.test.ts— the behavior-spec comment.New wording:
Notes
owl-import.md,reference.md) is corrected separately in the docs PR docs(semantic-model): audit the deploy guide for binding profiles + Spanner Graph #365.