fix(hashicorp/terraform-provider-google#8370): Converting non-legacy …

[sachinpro]

fix(hashicorp/terraform-provider-google#8370): Converting non-legacy BQ roles to legacy ones to suppress diff

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed `google_bigquery_dataset` to be stop showing diff on re-apply for non-legacy IAM roles because the API returns legacy ones.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 84 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 84 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 47 insertions(+))

[modular-magician]

Tests analytics

Total tests: 121
Passed tests: 105
Skipped tests: 10
Affected tests: 6

Click here to see the affected service packages

• bigquery

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryDataset_access
• TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample
• TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample
• TestAccBigQueryDataset_nonLegacyAccess
• TestAccBigqueryDatasetIamMember_afterDatasetCreation
• TestAccDataSourceGoogleBigqueryDataset_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryDataset_nonLegacyAccess[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDataset_access[Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample[Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample[Error message] [Debug log]
TestAccBigqueryDatasetIamMember_afterDatasetCreation[Error message] [Debug log]
TestAccDataSourceGoogleBigqueryDataset_basic[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 111 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 111 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 74 insertions(+))

[modular-magician]

Tests analytics

Total tests: 122
Passed tests: 104
Skipped tests: 10
Affected tests: 8

Click here to see the affected service packages

• bigquery

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryDatasetAccess_view
• TestAccBigQueryDataset_access
• TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample
• TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample
• TestAccBigQueryTable_TableReplicationInfo_WithReplicationInterval
• TestAccBigQueryTable_TableReplicationInfo_WithoutReplicationInterval
• TestAccBigqueryDatasetIamMember_afterDatasetCreation
• TestAccDataSourceGoogleBigqueryDataset_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryDataset_access [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedRoutineExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDatasetAccess_view [Error message] [Debug log]
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample [Error message] [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithReplicationInterval [Error message] [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithoutReplicationInterval [Error message] [Debug log]
TestAccBigqueryDatasetIamMember_afterDatasetCreation [Error message] [Debug log]
TestAccDataSourceGoogleBigqueryDataset_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 123 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 123 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

[modular-magician]

Tests analytics

Total tests: 122
Passed tests: 106
Skipped tests: 10
Affected tests: 6

Click here to see the affected service packages

• bigquery

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryDatasetAccess_view
• TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample
• TestAccBigQueryTable_TableReplicationInfo_WithReplicationInterval
• TestAccBigQueryTable_TableReplicationInfo_WithoutReplicationInterval
• TestAccBigqueryDatasetIamMember_afterDatasetCreation
• TestAccDataSourceGoogleBigqueryDataset_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryDataset_bigqueryDatasetAuthorizedDatasetExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDatasetAccess_view [Error message] [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithReplicationInterval [Error message] [Debug log]
TestAccBigQueryTable_TableReplicationInfo_WithoutReplicationInterval [Error message] [Debug log]
TestAccBigqueryDatasetIamMember_afterDatasetCreation [Error message] [Debug log]
TestAccDataSourceGoogleBigqueryDataset_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 130 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 130 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 93 insertions(+))

[modular-magician]

Tests analytics

Total tests: 122
Passed tests: 110
Skipped tests: 10
Affected tests: 2

Click here to see the affected service packages

• bigquery

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryDatasetIamMember_afterDatasetCreation
• TestAccDataSourceGoogleBigqueryDataset_basic

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccBigqueryDatasetIamMember_afterDatasetCreation [Error message] [Debug log]
TestAccDataSourceGoogleBigqueryDataset_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test