Terraform config for Firebase App Hosting Backend resource #13040

rainshen49 · 2025-02-11T15:12:45Z

Release Note Template for Downstream PRs (will be copied)

`google_firebase_app_hosting_backend`

modular-magician · 2025-02-11T15:24:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 359 insertions(+))
google-beta provider: Diff ( 12 files changed, 1885 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 193 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
  managed_resources {
    run_service {
      service = # value needed
    }
  }
}

rainshen49 · 2025-02-11T15:47:24Z

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:
resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

Note that codebase is hard to test in an automated fashion because it requires a real Github repo link, which can't be programmatically created. A human OAuth consent flow is required. However, an associated doc only example is provided.

github-actions · 2025-02-11T15:47:34Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-02-11T15:58:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 364 insertions(+))
google-beta provider: Diff ( 12 files changed, 1884 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 193 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
  managed_resources {
    run_service {
      service = # value needed
    }
  }
}

modular-magician · 2025-02-11T16:24:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 364 insertions(+))
google-beta provider: Diff ( 12 files changed, 1884 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 193 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

modular-magician · 2025-02-11T16:46:08Z

Tests analytics

Total tests: 4588
Passed tests: 4156
Skipped tests: 425
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendGithubExample

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample

TestAccSpannerInstance_spannerInstanceWithAutoscaling

Get to know how VCR tests work

modular-magician · 2025-02-11T17:04:44Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-11T17:21:21Z

Tests analytics

Total tests: 4588
Passed tests: 4155
Skipped tests: 425
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendGithubExample

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample

TestAccSpannerInstance_spannerInstanceWithAutoscaling

TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

modular-magician · 2025-02-11T17:41:00Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-11T17:46:36Z

Tests analytics

Total tests: 4588
Passed tests: 4156
Skipped tests: 425
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendGithubExample

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample

TestAccSpannerInstance_spannerInstanceWithAutoscaling

Get to know how VCR tests work

modular-magician · 2025-02-11T18:05:25Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-13T15:23:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 376 insertions(+))
google-beta provider: Diff ( 12 files changed, 1924 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 193 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

modular-magician · 2025-02-13T16:46:15Z

Tests analytics

Total tests: 4592
Passed tests: 4159
Skipped tests: 425
Affected tests: 8

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendGithubExample

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample

TestAccSpannerInstance_spannerInstanceWithAutoscaling

TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

modular-magician · 2025-02-13T17:05:53Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendBasicExample [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

rainshen49 · 2025-02-13T17:07:57Z

@roaks3 this PR is ready for review. The other test failures seem to be irrelevant.

github-actions · 2025-02-14T09:41:17Z

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-02-18T09:41:56Z

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2025-02-25T09:42:27Z

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

roaks3

Code LGTM, but had a few test-related comments

mmv1/products/firebaseapphosting/Backend.yaml

roaks3 · 2025-02-25T19:22:30Z

mmv1/templates/terraform/examples/firebase_app_hosting_backend_basic.tf.tmpl

@@ -0,0 +1,76 @@
+# Service account setup only required once per project.


For this example, are you intending for users to use this as a reference and potentially copy-and-paste this config as a canonical example to work from? I just couldn't tell, but if it is not suitable for documentation, you may want to rework things so that it does serve that audience (and you may want test-only or docs-only examples).

Yes, there are some setup that's required only once per project, as opposed to once per backend. It's common for users to just copy-pasta code, so I want them to at least copy everything they need.

roaks3 · 2025-02-25T19:24:17Z

mmv1/templates/terraform/examples/firebase_app_hosting_backend_basic.tf.tmpl

+  project = "{{index $.TestEnvVars "project_id"}}"
+
+  # Must be firebase-app-hosting-compute
+  account_id                   = "firebase-app-hosting-compute"


This should use vars so that it gets sweepable prefix/suffix added

This actually must be firebase-app-hosting-compute (see comment in the previous line). Otherwise, the experience in other surfaces (such as the Firebase Console UI) will be broken. This is publicly documented at https://firebase.google.com/support/guides/service-accounts

Ah sorry, thanks for clarifying!

roaks3 · 2025-02-25T19:24:27Z

mmv1/templates/terraform/examples/firebase_app_hosting_backend_basic.tf.tmpl

+  display_name                 = "Firebase App Hosting compute service account"
+
+  # Do not throw if already exists
+  create_ignore_already_exists = true


What is the purpose of including this? Tests should be deleting this account when they complete

See comment above (we have to use this name so sweepers can't reach it).

mmv1/templates/terraform/examples/firebase_app_hosting_backend_basic.tf.tmpl

mmv1/templates/terraform/examples/firebase_app_hosting_backend_github.tf.tmpl

modular-magician · 2025-02-28T02:59:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 563 insertions(+))
google-beta provider: Diff ( 13 files changed, 2089 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 195 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_firebase_app_hosting_backend

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-02-28T04:58:58Z

Tests analytics

Total tests: 4647
Passed tests: 4200
Skipped tests: 436
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendFullExample

TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendMinimalExample

TestAccFirebaseAppHostingBackend_update

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSpannerInstance_spannerInstanceWithAutoscaling

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-28T05:19:51Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendFullExample [Debug log]
TestAccFirebaseAppHostingBackend_firebaseAppHostingBackendMinimalExample [Debug log]
TestAccFirebaseAppHostingBackend_update [Debug log]
TestAccSpannerInstance_spannerInstanceWithAutoscaling [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-28T16:14:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2041 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2031 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 195 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_firebase_app_hosting_backend

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-02-28T18:13:54Z

Tests analytics

Total tests: 4647
Passed tests: 4204
Skipped tests: 436
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-02-28T18:33:11Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-02-28T23:22:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2041 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2031 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 195 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_firebase_app_hosting_backend

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-03-01T01:19:26Z

Tests analytics

Total tests: 4647
Passed tests: 4204
Skipped tests: 436
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-03-01T01:38:11Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-03-03T15:21:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2044 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2034 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 195 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_firebase_app_hosting_backend

If you believe this detection to be incorrect please raise the concern with your reviewer.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-03-03T17:20:41Z

Tests analytics

Total tests: 4651
Passed tests: 4208
Skipped tests: 436
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager

TestAccCloudbuildWorkerPool_basic

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-03-03T17:39:43Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2025-03-04T09:42:48Z

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

roaks3

LGTM, just one last nit.

I think the test/check failures are not related, although it might be worth a rebase to see if they resolve. The terraform-provider-missing-service-labels check is related to resource ownership for your team, so you'll need to use go/terraform-resource-owners-enrollment to get that set up if you haven't already.

mmv1/templates/terraform/examples/firebase_app_hosting_backend_full.tf.tmpl

roaks3 · 2025-03-06T22:47:55Z

Could you try another rebase before merge to see if the checks will resolve. Also, if you haven't already, please follow up by enrolling for resource ownership per terraform-provider-missing-service-labels

rainshen49 · 2025-03-07T15:03:48Z

cl/734321905

roaks3

This is just blocked on a rebase of the branch to bring in the latest changes from main, which should at a minimum resolve the failed TeamCity check

modular-magician · 2025-03-11T18:19:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 2044 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 13 files changed, 2034 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 195 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firebase_app_hosting_backend (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firebase_app_hosting_backend" "primary" {
  codebase {
    repository     = # value needed
    root_directory = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

google_firebase_app_hosting_backend

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

modular-magician · 2025-03-11T20:20:35Z

Tests analytics

Total tests: 4681
Passed tests: 4233
Skipped tests: 436
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudbuildWorkerPool_basic

TestAccComputeInstanceFromMachineImage_terminationTime

TestAccComputeInstanceFromTemplate_TerminationTime

TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime

TestAccComputeInstance_schedulingTerminationTime

TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime

TestAccDNSRecordSet_routingPolicy

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample

TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

TestAccSqlUser_password_wo

Get to know how VCR tests work

modular-magician · 2025-03-11T20:37:57Z

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceFromMachineImage_terminationTime [Debug log]
TestAccComputeInstanceFromTemplate_TerminationTime [Debug log]
TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccComputeInstance_schedulingTerminationTime [Debug log]
TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_basic [Error message] [Debug log]
TestAccDNSRecordSet_routingPolicy [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample [Error message] [Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample [Error message] [Debug log]
TestAccSqlUser_password_wo [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician added the service/firebase label Feb 11, 2025

modular-magician requested a review from mraouffouad February 11, 2025 15:24

rainshen49 marked this pull request as ready for review February 11, 2025 15:46

github-actions bot requested a review from roaks3 February 11, 2025 15:47

rainshen49 force-pushed the apphosting branch from f4be781 to debde51 Compare February 11, 2025 16:12

roaks3 requested changes Feb 25, 2025

View reviewed changes

github-actions bot requested a review from roaks3 February 28, 2025 02:49

rainshen49 force-pushed the apphosting branch from 766d8aa to bdaee54 Compare February 28, 2025 16:03

rainshen49 force-pushed the apphosting branch from bdaee54 to 5ac6ba8 Compare February 28, 2025 23:10

roaks3 approved these changes Mar 5, 2025

View reviewed changes

mmv1/templates/terraform/examples/firebase_app_hosting_backend_full.tf.tmpl Show resolved Hide resolved

github-actions bot requested a review from roaks3 March 7, 2025 15:04

roaks3 reviewed Mar 10, 2025

View reviewed changes

rainshen49 added 8 commits March 11, 2025 11:07

Terraform config for App Hosting Backend resource

6b3d291

Add service account setup

bbd4aca

Add firebaseapphosting to teamcity

d7dab18

Mark managetResources as output

575d566

Add API enablement for firebaseapphosting

40d93c3

Add more tests & hard-code unimportant fields

f372f5f

Add ga tests

f36b1ac

Reorder example to be dependencies last

30ea91e

rainshen49 force-pushed the apphosting branch from d7e7831 to 30ea91e Compare March 11, 2025 18:07

github-actions bot requested a review from roaks3 March 11, 2025 18:08

		@@ -0,0 +1,76 @@
		# Service account setup only required once per project.

Terraform config for Firebase App Hosting Backend resource #13040

Are you sure you want to change the base?

Terraform config for Firebase App Hosting Backend resource #13040

Conversation

rainshen49 commented Feb 11, 2025 • edited Loading

modular-magician commented Feb 11, 2025

Diff report

Missing test report

rainshen49 commented Feb 11, 2025 • edited Loading

Missing test report

github-actions bot commented Feb 11, 2025

modular-magician commented Feb 11, 2025

Diff report

Missing test report

modular-magician commented Feb 11, 2025

Diff report

Missing test report

modular-magician commented Feb 11, 2025

Tests analytics

Action taken

modular-magician commented Feb 11, 2025

modular-magician commented Feb 11, 2025

Tests analytics

Action taken

modular-magician commented Feb 11, 2025

modular-magician commented Feb 11, 2025

Tests analytics

Action taken

modular-magician commented Feb 11, 2025

modular-magician commented Feb 13, 2025

Diff report

Missing test report

modular-magician commented Feb 13, 2025

Tests analytics

Action taken

modular-magician commented Feb 13, 2025

rainshen49 commented Feb 13, 2025

github-actions bot commented Feb 14, 2025

github-actions bot commented Feb 18, 2025

github-actions bot commented Feb 25, 2025

roaks3 left a comment

Choose a reason for hiding this comment

roaks3 Feb 25, 2025

Choose a reason for hiding this comment

rainshen49 Feb 28, 2025

Choose a reason for hiding this comment

roaks3 Feb 25, 2025

Choose a reason for hiding this comment

rainshen49 Feb 28, 2025

Choose a reason for hiding this comment

roaks3 Mar 5, 2025

Choose a reason for hiding this comment

roaks3 Feb 25, 2025

Choose a reason for hiding this comment

rainshen49 Feb 28, 2025

Choose a reason for hiding this comment

modular-magician commented Feb 28, 2025

Diff report

Missing test report

Missing service labels

modular-magician commented Feb 28, 2025

Tests analytics

Action taken

modular-magician commented Feb 28, 2025

modular-magician commented Feb 28, 2025

Diff report

Missing test report

Missing service labels

modular-magician commented Feb 28, 2025

Tests analytics

Action taken

modular-magician commented Feb 28, 2025

modular-magician commented Feb 28, 2025

Diff report

Missing test report

Missing service labels

modular-magician commented Mar 1, 2025

Tests analytics

Action taken

modular-magician commented Mar 1, 2025

rainshen49 commented Feb 11, 2025 •

edited

Loading

rainshen49 commented Feb 11, 2025 •

edited

Loading