Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Logical Views #13306

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Mar 10, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_bigtable_logical_view`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 730 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 730 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_logical_view (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_logical_view" "primary" {
  logical_view_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableLogicalView_bigtableLogicalViewExample
  • TestAccBigtableLogicalView_update
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 739 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 739 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_logical_view (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_logical_view" "primary" {
  logical_view_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableLogicalView_bigtableLogicalViewExample
  • TestAccBigtableLogicalView_update
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 739 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 739 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigtable_logical_view (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigtable_logical_view" "primary" {
  logical_view_id = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableLogicalView_bigtableLogicalViewExample
  • TestAccBigtableLogicalView_update
    🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 739 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 739 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 135 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableLogicalView_bigtableLogicalViewExample
  • TestAccBigtableLogicalView_update
    🟢 All tests passed!

View the build log

@ron-gal ron-gal marked this pull request as ready for review March 11, 2025 17:15
@github-actions github-actions bot requested a review from rileykarson March 11, 2025 17:16
Copy link

github-actions bot commented Mar 11, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@melinath
Copy link
Member

@modular-magician reassign-reviewer melinath

@github-actions github-actions bot requested a review from melinath March 11, 2025 17:32
@melinath melinath removed the request for review from rileykarson March 11, 2025 18:23
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 737 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 737 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 134 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 53
Passed tests: 0
Skipped tests: 53
Affected tests: 0

Click here to see the affected service packages
  • bigtable
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccBigtableLogicalView_bigtableLogicalViewExample
  • TestAccBigtableLogicalView_update
    🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants