Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue-21766 data google_compute_image fails on destroy if image d… #13308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjogdand
Copy link

@mjogdand mjogdand commented Mar 10, 2025

Fixes hashicorp/terraform-provider-google#21766

compute: fixed data fails on destroy if image path doesn't exist in `google_compute_image`

@github-actions github-actions bot requested a review from shuyama1 March 10, 2025 16:24
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 10, 2025
@mjogdand
Copy link
Author

@shuyama1 - Can you please advice on the change?

@modular-magician modular-magician added service/compute-pd and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 10 insertions(+))
google-beta provider: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1135
Passed tests: 1056
Skipped tests: 79
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data "google_compute_image" fails on destroy path if image doesn't exist
2 participants