Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing "force" (delete) argument to google_dataform_repository resource #13309

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sdsilva1
Copy link

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

dataform: added "custom_code:pre-delete", "virtual_fields:deletion_policy" to "google_dataform_repository"

@github-actions github-actions bot requested a review from trodge March 10, 2025 16:27
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 36 insertions(+), 197 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field service_account within resource google_dataform_repository was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataform_repository (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataform_repository" "primary" {
  deletion_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataform

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@sdsilva1 sdsilva1 marked this pull request as draft March 10, 2025 16:55
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 4 files changed, 36 insertions(+), 164 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataform_repository (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataform_repository" "primary" {
  deletion_policy = # value needed
}

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 4 files changed, 36 insertions(+), 164 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataform_repository (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataform_repository" "primary" {
  deletion_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataform

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 8
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataform

🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants