Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Managed Kafka ConnectCluster and Connector resources and tests #13310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johndee7310
Copy link

@johndee7310 johndee7310 commented Mar 10, 2025

Description: Adding a new Managed Kafka ConnectCluster and Connector terraform resources to terraform-provider-google-beta. Includes basic create tests.

These resources were added to magic-modules-private-overrides and will be removed by the following CL: https://cloud-internal-review.git.corp.google.com/c/cloud-graphite-eng/magic-modules-private-overrides/+/50910

Issue: https://b.corp.google.com/issues/349869451

Release Note

See Write release notes for guidance.

`google_managed_kafka_connect_cluster` (beta)
`google_managed_kafka_connector` (beta)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 447 insertions(+))
google-beta provider: Diff ( 10 files changed, 2335 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 355 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_managed_kafka_connect_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_managed_kafka_connect_cluster" "primary" {
  config = # value needed
  gcp_config {
    access_config {
      network_configs {
        additional_subnets = # value needed
        dns_domain_names   = # value needed
      }
    }
  }
}

Resource: google_managed_kafka_connector (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_managed_kafka_connector" "primary" {
  task_restart_policy {
    maximum_backoff = # value needed
    minimum_backoff = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 614f9d9 to 2c8be7d Compare March 10, 2025 18:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 447 insertions(+))
google-beta provider: Diff ( 10 files changed, 2335 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 355 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_managed_kafka_connect_cluster (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_managed_kafka_connect_cluster" "primary" {
  config = # value needed
  gcp_config {
    access_config {
      network_configs {
        additional_subnets = # value needed
        dns_domain_names   = # value needed
      }
    }
  }
}

Resource: google_managed_kafka_connector (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_managed_kafka_connector" "primary" {
  task_restart_policy {
    maximum_backoff = # value needed
    minimum_backoff = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 2c8be7d to f5bd7c5 Compare March 11, 2025 16:30
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 479 insertions(+))
google-beta provider: Diff ( 10 files changed, 2362 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_managed_kafka_connect_cluster (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_managed_kafka_connect_cluster" "primary" {
  capacity_config {
    memory_bytes = # value needed
    vcpu_count   = # value needed
  }
  connect_cluster_id = # value needed
  gcp_config {
    access_config {
      network_configs {
        additional_subnets = # value needed
        dns_domain_names   = # value needed
        primary_subnet     = # value needed
      }
    }
  }
  kafka_cluster = # value needed
  labels        = # value needed
  location      = # value needed
}

Resource: google_managed_kafka_connector (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_managed_kafka_connector" "primary" {
  configs         = # value needed
  connect_cluster = # value needed
  connector_id    = # value needed
  location        = # value needed
  task_restart_policy {
    maximum_backoff = # value needed
    minimum_backoff = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from f5bd7c5 to dab8ca3 Compare March 11, 2025 16:47
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 479 insertions(+))
google-beta provider: Diff ( 10 files changed, 2362 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from dab8ca3 to 662523a Compare March 11, 2025 17:12
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 479 insertions(+))
google-beta provider: Diff ( 10 files changed, 2362 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 662523a to 020a541 Compare March 11, 2025 18:47
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 472 insertions(+))
google-beta provider: Diff ( 10 files changed, 2348 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 020a541 to ac66585 Compare March 11, 2025 22:35
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 480 insertions(+))
google-beta provider: Diff ( 10 files changed, 2364 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch 2 times, most recently from cdc2694 to 3b4d63e Compare March 11, 2025 22:56
@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 3b4d63e to 40609ef Compare March 11, 2025 23:49
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 480 insertions(+))
google-beta provider: Diff ( 10 files changed, 2364 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 40609ef to 1080665 Compare March 12, 2025 00:38
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 480 insertions(+))
google-beta provider: Diff ( 10 files changed, 2364 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 1080665 to c4ef907 Compare March 12, 2025 02:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 480 insertions(+))
google-beta provider: Diff ( 10 files changed, 2364 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from c4ef907 to c082252 Compare March 12, 2025 02:47
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 480 insertions(+))
google-beta provider: Diff ( 10 files changed, 2364 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from c082252 to 49d71d2 Compare March 12, 2025 03:34
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 466 insertions(+))
google-beta provider: Diff ( 10 files changed, 2336 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@johndee7310 johndee7310 force-pushed the add-managedkafkaconnect-resources branch from 49d71d2 to 8379296 Compare March 12, 2025 04:45
@johndee7310 johndee7310 marked this pull request as ready for review March 12, 2025 04:46
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from shuyama1 March 12, 2025 04:46
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 466 insertions(+))
google-beta provider: Diff ( 10 files changed, 2336 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 338 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • managedkafka

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccManagedKafkaConnectCluster_managedkafkaConnectClusterBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants