Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance lifecycle policy on failed health check action implementation #13320

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RooBarsic
Copy link
Contributor

@RooBarsic RooBarsic commented Mar 11, 2025

This Creates (R)IGM.InstanceLifecyclePolicy.OnFailedHealthCheck functionalities in Beta . Modifies Compute (Region)InstanceGroupManagers.

All the IGM and RIGM tests have been ran and pass.

fixes hashicorp/terraform-provider-google#21807

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `instance_lifecycle_policy.on_failed_health_check` field in resources `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager`

@github-actions github-actions bot requested a review from NickElliot March 11, 2025 14:43
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement InstanceLifecyclePolicy.OnFailedHealthCheck for compute_(region_)instance_group_managers
2 participants