Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile Dataproc Metastore Autoscaling Configs w/ API status #13325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Noremac201
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#21812

metastore: promoted `scaling_config` field to GA

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from roaks3 March 11, 2025 17:31
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 11, 2025
Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except for the mentioned example file

@github-actions github-actions bot requested a review from roaks3 March 11, 2025 20:40
@modular-magician modular-magician added service/metastore and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 387 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 32 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 27
Passed tests: 25
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages
  • dataprocmetastore
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample
    🟢 All tests passed!

View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconcile Dataproc Metastore Autoscaling Configs w/ API status
3 participants