Reservation Affinity for workbench instances

[bcreddy-gcp]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: added `reservation_affinity` field to `google_workbench_instance` resource.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 471 insertions(+))
google-beta provider: Diff ( 4 files changed, 471 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 93 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 153 insertions(+))

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 21
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• workbench

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample
• TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample
• TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[BBBmau]

looks like the tests are causing an unwanted force replacement on this.

                  ~ network_interfaces (known after apply)
                  - network_interfaces {
                      - network  = "https://www.googleapis.com/compute/v1/projects/ci-test-project-188019/global/networks/default" -> null
                      - subnet   = "https://www.googleapis.com/compute/v1/projects/ci-test-project-188019/regions/us-central1/subnetworks/default" -> null
                        # (1 unchanged attribute hidden)
        
                      - access_configs {
                          - external_ip = "34.121.56.226" -> null
                        }
                    }
        
                  + reservation_affinity { # forces replacement
                      + consume_reservation_type = "RESERVATION_ANY" # forces replacement
                    }
        
                  ~ service_accounts (known after apply)
                  - service_accounts {
                      - email  = "[email protected]" -> null
                      - scopes = [
                          - "https://www.googleapis.com/auth/cloud-platform",
                          - "https://www.googleapis.com/auth/userinfo.email",
                        ] -> null
                    }

It doesn't seem to be get added into state since a second apply shows us that it's attempting to add it. Can you take a look as to what could be causing this?

[bcreddy-gcp]

API rollout for these fields is not yet done which is causing this issue. I didn't face this on my local since I have the required visibility labels for these fields. We can revisit this after the rollout is done.