Fix vertex_ai_index_endpoint_deployed_index import without provider region#17477
Open
Shuanglu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Fix vertex_ai_index_endpoint_deployed_index import without provider region#17477Shuanglu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Shuanglu wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4f67e8d to
8d659c8
Compare
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At terraform import time the .tf config is not yet applied to the schema, so d.Get("region") is empty and tpgresource.GetRegion falls through to the provider config. When provider-level region/zone is unset, Read fails with "Cannot determine region" because the URL is templated on {{region}}. Parse region (and project) from the index_endpoint path in the import ID and d.Set them so Read can resolve the URL.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.