Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compute_snapshot_schedule_attach/list #3926

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Dec 2, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 2, 2024
@gryczj gryczj requested review from a team as code owners December 2, 2024 15:09
Copy link

snippet-bot bot commented Dec 2, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 2, 2024
Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gryczj and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request adds functionality for managing Compute Engine snapshot schedules. Specifically, it introduces three new JavaScript samples:

  • createSnapshotSchedule.js: Creates a new snapshot schedule with customizable settings (daily, weekly, or monthly; retention policy; labels).
  • attachSnapshotSchedule.js: Attaches an existing snapshot schedule to a Compute Engine disk.
  • deleteSnapshotSchedule.js: Deletes a snapshot schedule. Note that this will fail if the schedule is attached to a disk.

Each sample includes comprehensive comments and error handling. Unit tests are also provided in attachSnapshotSchedule.test.js to verify the functionality.

The intent is to provide developers with clear, concise examples for working with Compute Engine snapshot schedules using the Node.js client library. This enhances the documentation and makes it easier for users to automate disk snapshots.


And now, a little haiku to lighten the mood:

Code flows like a stream,
Tests run, bugs swim downstream,
Clean code shines so bright.

Looking forward to the discussion!

@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Dec 2, 2024
@gryczj gryczj requested a review from iennae December 2, 2024 15:10
@gryczj gryczj force-pushed the compute_snapshot_schedule_attach branch from 149ac9e to 307b652 Compare December 2, 2024 15:10
@@ -0,0 +1,103 @@
/*
* Copyright 2024 Google LLC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample was added for testing purposes

* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample was added for testing purposes

@gryczj gryczj force-pushed the compute_snapshot_schedule_attach branch from 84d3b32 to 422a024 Compare December 3, 2024 08:21
@gryczj gryczj force-pushed the compute_snapshot_schedule_attach branch from 422a024 to 0397137 Compare December 4, 2024 13:35
@gryczj gryczj changed the title feat: compute_snapshot_schedule_attach feat: compute_snapshot_schedule_attach/list Dec 4, 2024
@BigBlackWolf BigBlackWolf self-requested a review December 5, 2024 11:55
@kweinmeister
Copy link
Collaborator

Can you please try to fix the conflict @gryczj ?

@rsamborski
Copy link
Member

@BigBlackWolf PTAL

@BigBlackWolf
Copy link

Oh, I noticed that wrote a comment, but didn't submit 😅 Thanks, @rsamborski

Can you please try to fix the conflict @gryczj ?

Joanna is on vacations and I am going to support her with open PRs. @kweinmeister I've resolved the conflicts, do you have any other concerns?

Copy link
Contributor

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

@iennae
Copy link
Contributor

iennae commented Dec 19, 2024

@code-review-assist walkthrough

1 similar comment
@umairidris
Copy link
Member

@code-review-assist walkthrough

Copy link
Contributor

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

@umairidris
Copy link
Member

@code-review-assist walkthrough

Copy link
Contributor

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

@umairidris
Copy link
Member

@code-review-assist walkthrough

Copy link
Contributor

Gemini encountered an error creating the walkthrough. You can try again by commenting @code-review-assist walkthrough.

@m-strzelczyk
Copy link
Contributor

The users that are currently failing CLA had CLA signed at the time they were committing the changes. Please force-merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants