Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/tpcc/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
<dependency>
<groupId>com.google.googlejavaformat</groupId>
<artifactId>google-java-format</artifactId>
<version>1.28.0</version>
<version>1.37.0</version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The google-java-format version 1.37.0 requires JDK 21 or higher to run. However, this project targets Java 17 (<java.version>17</java.version>) and the fmt-maven-plugin is configured directly in the main <build> section. If built using JDK 17, the build will fail.\n\nPlease wrap the fmt-maven-plugin configuration in a profile that is only activated on JDK 21 or higher (e.g., <jdk>[21,)</jdk>), similar to the root pom.xml configuration.

</dependency>
</dependencies>
</plugin>
Expand Down
2 changes: 1 addition & 1 deletion samples/snippets/java-snippets/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<dependency>
<groupId>com.google.googlejavaformat</groupId>
<artifactId>google-java-format</artifactId>
<version>1.28.0</version>
<version>1.37.0</version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The google-java-format version 1.37.0 requires JDK 21 or higher to run. However, the format profile in this pom.xml is currently configured to activate on JDK 17 and above (<jdk>[17,)</jdk> at line 61). Running the build on JDK 17 will fail with an UnsupportedClassVersionError. Please update the profile activation to <jdk>[21,)</jdk> to match the JDK 21 requirement of the new google-java-format version.

</dependency>
</dependencies>
</plugin>
Expand Down
Loading