Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand VPA to all GMP components #1209

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

bernot-dev
Copy link
Collaborator

@bernot-dev bernot-dev commented Jan 7, 2025

Prior to this change, when the VPA feature is enabled, it is only used to autoscale the collector pods.

This change expands the VPA feature to autoscale the alertmanager, rule-evaluator, and operator.

Fixes #975

@bernot-dev bernot-dev added the enhancement New feature or request label Jan 7, 2025
@bernot-dev bernot-dev self-assigned this Jan 7, 2025
@bernot-dev bernot-dev force-pushed the bernot-dev/expand-vpa branch 2 times, most recently from 0fdf8ad to d58bd27 Compare January 7, 2025 21:54
@bernot-dev bernot-dev force-pushed the bernot-dev/expand-vpa branch from d58bd27 to c6c0323 Compare January 13, 2025 16:52
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, let's just make sure to add more documentation on the type vpa OperatorConfig field to make this explicit.

Thanks!

@bernot-dev bernot-dev force-pushed the bernot-dev/expand-vpa branch from c6c0323 to 037383d Compare January 14, 2025 18:35
@bernot-dev bernot-dev merged commit b8427b4 into main Jan 14, 2025
27 checks passed
@bernot-dev bernot-dev deleted the bernot-dev/expand-vpa branch January 14, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable VPA feature for rule-evaluator
2 participants