fix: e2e test timeout 3 #1379
Draft
fix: e2e test timeout 3 #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henrique Spanoudis Matulis <[email protected]>
|
Tip: You can convert it to a draft to show it's an experiment. |
|
Looks like it works? |
Yeah, looks like the longest e2e test took 11 minutes. Maybe just an incremental performance regression in the e2e tests. I'm curious if this performance difference is detectable in Prombench. It could actually be related to the newer version of Go, but that might be difficult to isolate with confidence. |
Done!
To clarify for posterity: this PR targets a release/0.15~3 to bisect the issue. The issue ended up being related to the metadata changes here 953d736 being skewed from our released tags, which should now be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
This PR is meant to test the whether e2e test timeouts affecting the 0.15 release branch affect the commit of the last PR merged in