Skip to content

Fix: Remove deletion_protection variable argument#275

Closed
regisferlima wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
regisferlima:main
Closed

Fix: Remove deletion_protection variable argument#275
regisferlima wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
regisferlima:main

Conversation

@regisferlima
Copy link
Copy Markdown

@regisferlima regisferlima commented Dec 10, 2024

We are facing an issue with the new version of 0.15.3

Something is out of sync with the API and the official documentation of Terraform and the module.

Seems that **deletion_protection** is not expected on the resource "google_cloud_run_v2_service"

image

@regisferlima regisferlima requested review from a team, anamer, gtsorbo, prabhu34 and q2w as code owners December 10, 2024 14:22
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Dec 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@regisferlima regisferlima changed the title Remove deletion_protection variable argument Fix: Remove deletion_protection variable argument Dec 10, 2024
@regisferlima
Copy link
Copy Markdown
Author

/gcbrun

@apeabody
Copy link
Copy Markdown
Contributor

Hi @regisferlima - It looks like deletion_protection was added in TPGv6.0, can you try upgrading your provider? e.g terraform init --upgrade.

Hi @daniel-cit - As a follow-up to #257, could we add a >= 6 to the Terraform version constraint.

@regisferlima
Copy link
Copy Markdown
Author

regisferlima commented Dec 10, 2024

Sounds good, everyone! Thank you! I just added the variable as cloud_run_deletion_protection = false

@regisferlima
Copy link
Copy Markdown
Author

Maybe we could pass it as optional? because when I'm using the module, it always says that deletion_protection should not expected there.

image

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions Bot added the Stale label Feb 10, 2025
@github-actions github-actions Bot closed this Feb 18, 2025
marcelorobj pushed a commit to marcelorobj/terraform-google-cloud-run that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants