-
Notifications
You must be signed in to change notification settings - Fork 420
Honor new application DSL from KMP 2.1.20 #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Goooler
wants to merge
16
commits into
main
Choose a base branch
from
g/20250311/kotlin-new-app-block
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
20ae88a
Update 2.1.20-RC2
Goooler 876267a
Find new things in `kmpExtension.jvm().binaries`
Goooler 353aa3d
Test `compatKmpApplicationDsl`
Goooler 1bcf07c
Apply ShadowApplicationPlugin for KMP
Goooler 94e46e4
Merge remote-tracking branch 'origin/main' into g/20250311/kotlin-new…
Goooler 2da7c75
Rename ShadowApplicationPlugin to ShadowJavaAppPlugin
Goooler 271ccdb
Explicit ShadowKmpAppPlugin
Goooler 918c1a3
Merge remote-tracking branch 'origin/main' into g/20250311/kotlin-new…
Goooler 1d6150a
Fix merge
Goooler f7964a0
Move runShadow registering into executable block
Goooler ec62de4
Merge remote-tracking branch 'origin/main' into g/20250311/kotlin-new…
Goooler 11bf490
Dump API
Goooler c566f27
Merge remote-tracking branch 'origin/main' into g/20250311/kotlin-new…
Goooler 8a5e686
Merge remote-tracking branch 'origin/main' into g/20250311/kotlin-new…
Goooler 1a4e97f
Reverts
Goooler 13491f7
Merge remote-tracking branch 'origin/main' into g/20250311/kotlin-new…
Goooler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way to defer
binaries
andexecutable
? I seebinariesDsl
is private, we can't use it...https://github.com/JetBrains/kotlin/blob/0cdd9f9deb7ea0e89a3cfdd364adeb617a716e04/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/jvm/KotlinJvmTarget.kt#L98-L104
CC @antohaby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC @osipxd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created an issue to address this:
KT-77499 Provide a way to access and configure JVM binaries defined by users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feedback!