Skip to content

Comments

Create outline with "non-scaling-stroke" SVG tag#2437

Closed
EllenGYY wants to merge 12 commits intoGraphiteEditor:masterfrom
EllenGYY:add-non-scaling-stroke-option
Closed

Create outline with "non-scaling-stroke" SVG tag#2437
EllenGYY wants to merge 12 commits intoGraphiteEditor:masterfrom
EllenGYY:add-non-scaling-stroke-option

Conversation

@EllenGYY
Copy link
Contributor

@EllenGYY EllenGYY commented Mar 14, 2025 •
edited by Keavon
Loading

Superseded by #2455.

Uses `vector-effect="non-scaling-stroke"` for outline rendering to ensure the stroke is unaffected by the parent’s transform.
The normal rendering behavior remains unchanged. 

Closes #2435

@Keavon Keavon requested a review from TrueDoctor March 15, 2025 09:51
@Keavon Keavon force-pushed the master branch 4 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
@Keavon
Copy link
Member

Keavon commented Apr 7, 2025

Superseded by #2455.

@Keavon Keavon closed this Apr 7, 2025
@Keavon
Copy link
Member

Keavon commented Apr 7, 2025

I didn't realize that was a stacked branch on top of this one since the description didn't mention it, so that was merged with both included. No harm done though! That's a logical scope for that PR to include both parts.

@Keavon Keavon removed the request for review from TrueDoctor April 7, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EllenGYY @Keavon