-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of gaussian blur and box blur and raster node category #2477
base: master
Are you sure you want to change the base?
Conversation
Typo in commit message |
I'll try to review this tomorrow. |
Is there a specific reason why you chose to convert this to an image data type first instead of using or inbuilt one? Also @Keavon should blur happen in srgb or linear? They should give different results, so we have to think about which one is correct / what is compatible with other tools |
It also looks like the current implementation quantizes the values to 8 bit which is most likely not what we want. We should also take SIMD friendliness into account here and potentially try to re-enable that target flag and hope that the chrome bug from two years ago has been fixed |
We should have both linear and gamma, with linear as default. https://www.youtube.com/watch?v=LKnqECcg6Gw |
…lorspace in raster category
606c186
to
4182032
Compare
I've updated it to convert from linear/nonlinear before/after blurring using the functions from graphene_core::raster::Channel and changed from u8 values to f32 |
Thanks. In the future, could you please add your followup work as additional commits instead of amending the original commit, so it's possible to compare them? |
Yes ill keep that in mind |
A couple code review notes before I do a proper code review:
|
aa7ff13
to
e11b57a
Compare
Closes #995
Implements both gaussian and box blurs under raster category
Screen.Recording.mp4