Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for document panning, zooming, and rotating #2492

Merged
merged 9 commits into from
Mar 31, 2025

Conversation

rahat2134
Copy link
Contributor

Fixes a part of #2465

Added tests to verify that transform operations work correctly when the document view is panned, zoomed, or rotated.

@rahat2134
Copy link
Contributor Author

@0HyperCube PTAL whenever possible and let me know if I implement it correctly!

Thanks.

p.s- I am really enjoying writing these tests XD

@rahat2134 rahat2134 changed the title Added tests for panned, zoomed, and rotated Added tests for document panning, zooming, and rotating. Mar 27, 2025
@rahat2134 rahat2134 requested a review from 0HyperCube March 27, 2025 21:56
@rahat2134
Copy link
Contributor Author

Hey @0HyperCube Is this looking good now?

Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for working on this.

@0HyperCube 0HyperCube merged commit dfb164d into GraphiteEditor:master Mar 31, 2025
4 checks passed
Keavon pushed a commit that referenced this pull request Mar 31, 2025
* add tests for panned, zoomed, and rotated

* add tests for panned, zoomed, and rotated

* Did some changes for grs system

* change
@Keavon Keavon changed the title Added tests for document panning, zooming, and rotating. Add tests for document panning, zooming, and rotating Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants