-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for document panning, zooming, and rotating #2492
Merged
0HyperCube
merged 9 commits into
GraphiteEditor:master
from
rahat2134:pann-rotate-zoom-test
Mar 31, 2025
Merged
Add tests for document panning, zooming, and rotating #2492
0HyperCube
merged 9 commits into
GraphiteEditor:master
from
rahat2134:pann-rotate-zoom-test
Mar 31, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@0HyperCube PTAL whenever possible and let me know if I implement it correctly! Thanks. p.s- I am really enjoying writing these tests XD |
0HyperCube
requested changes
Mar 27, 2025
editor/src/messages/tool/transform_layer/transform_layer_message_handler.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/tool/transform_layer/transform_layer_message_handler.rs
Outdated
Show resolved
Hide resolved
…nto pann-rotate-zoom-test
…Graphite into pann-rotate-zoom-test
Hey @0HyperCube Is this looking good now? |
0HyperCube
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; thanks for working on this.
Keavon
pushed a commit
that referenced
this pull request
Mar 31, 2025
* add tests for panned, zoomed, and rotated * add tests for panned, zoomed, and rotated * Did some changes for grs system * change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of #2465
Added tests to verify that transform operations work correctly when the document view is panned, zoomed, or rotated.