Add testing setup #2177
Open
Add testing setup #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with Chromium connecting to the Docker container via the WebSocket.
This is the minimum supported GravityView version
Ref: https://playwright.dev/docs/api/class-page#page-wait-for-navigation Also, the use of "networkidle" is discouraged.
This is an attempt to fix the "Error: Error establishing a database connection" issue since we can't override WP-ENV's Docker setup and add a `healthcheck` (or can we? :)).
3s may not be enough as it's possible that Foundation is fetching updates/etc. on first load.
@Mwalek, it runs 10 tests—this approach needs adjustment. Also, I’d rather not add a global command specific to some environment. We can use CCI's config.yml for that.
|
@Mwalek, I added some code to retry the Please update all tests to not use the |
1) Playwright's config is no longer concerned w/authentication 2) New state fiel is created if does not exist, existing one is validated and recreated if invalid 3) gotoAndEnsureLoggedIn() helper can be dropped
mrcasual
reviewed
Feb 20, 2025
| @@ -13,7 +12,7 @@ test("Verify Allow Rest Access Checked", async ({ page }, testInfo) => { | |||
| let currentUrl, params, viewId, apiUrl, response; | |||
|
|
|||
| await test.step("Log in and navigate to the appropriate page", async () => { | |||
There was a problem hiding this comment.
@Mwalek, we don't really need to describe this step here and elsewhere. Just do page.goto('/wp-admin/edit.php?post_type=gravityview');.
mrcasual
reviewed
Feb 20, 2025
| @@ -15,7 +14,7 @@ test("Verify Prevent Direct Access", async ({ browser }, testInfo) => { | |||
| const page = await loggedInContext.newPage(); | |||
|
|
|||
| await test.step("Log in and create the View", async () => { | |||
There was a problem hiding this comment.
@Mwalek, Log in and create the View > Create the View
Usage: USE_LOCAL_BROWSER=1 npm run tests:e2e:run This requires Playwright to be globally installed (npx playwright install).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💾 Build file (f33a0c4).