[WIP] Add style presets #2276
Open
[WIP] Add style presets #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs a lot of work, but I wanted to get a starting point going. Here's a video showing that it works to load the View styles, it also applies the styles in the block editor, and starts to look okay. - [ ] We need to compile the CSS from source - [ ] Add the GF Orbital theme CSS - [ ] Figure out how to handle namespacing per-View. Should we load the CSS into memory and then output inline? We discussed this option at WCEU 2024. - [ ] Clean up copypasta - [ ] Use a nicer dropdown that can show a preview of the styles - [ ] …Probably many other things. https://www.loom.com/share/ae7f0b460b5f43418dbf98a9faec3db6
This is a placeholder for now.
This is based on the work for the Dashboard Views.
This is very work-in-progress, still trying to figure out the best way to show the different frameworks. https://i.gravitykit.com/i/oGyXVm
We only need to instantiate the styles when getting their name, and only then because the names need to be translated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1917 and is a start to including more default style options.
This is based on the work done in Dashboard Views and uses the code structure of the work done in the Lightbox Provider functionality.
Todo:
💾 Build file (8b4b977).