Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds full date to compare correctly #2284

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Conversation

omarkasem
Copy link
Collaborator

@omarkasem omarkasem commented Feb 13, 2025

💾 Build file (cff8937).

@omarkasem omarkasem linked an issue Feb 13, 2025 that may be closed by this pull request
@omarkasem omarkasem requested a review from mrcasual February 13, 2025 16:47
@omarkasem omarkasem self-assigned this Feb 13, 2025
@omarkasem
Copy link
Collaborator Author

@mrcasual Those test failures are not related to this PR, It didn't show up to me locally until i updated to latest gravity forms version

@mrcasual
Copy link
Collaborator

@mrcasual Those test failures are not related to this PR, It didn't show up to me locally until i updated to latest gravity forms version

@omarkasem, please rebase on develop and make sure to always do so before submitting a PR. This ensures that you're using the latest codebase. Those errors were fixed yesterday and included in the 2.35 release.

@omarkasem
Copy link
Collaborator Author

@mrcasual Yes my bad, I tried to merge before and it was up to date but i forgot that haven't checked out develop in some time

@mrcasual mrcasual merged commit 8dcb8cb into develop Feb 16, 2025
1 check passed
@mrcasual mrcasual deleted the issue/2263-fix-flaky-test branch February 16, 2025 13:53
mrcasual added a commit that referenced this pull request Feb 16, 2025
This reverts commit 8dcb8cb, reversing
changes made to f34cb22.
@mrcasual mrcasual restored the issue/2263-fix-flaky-test branch February 16, 2025 13:58
@mrcasual
Copy link
Collaborator

@mrcasual mrcasual mentioned this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky test
2 participants