fix(ci): align build and release workflow with deploy workflow#1167
Merged
dadiorchen merged 1 commit intoGreenstand:hotfix/new-masterfrom Nov 1, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the prepare job in build_and_release.yaml workflow to use the same environment resolution logic as deploy.yml workflow. It ensures that the resources are selected based on both the release channel and target environment (dev, test, prod). This eliminates mismatches where Build & Release previously deployed to the wrong environment.
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
The build_and_release.yaml workflow resolves deployment targets using only the release channel (e.g., master, freetown) and ignores the environment (dev, test, prod). This causes deployments to go to incorrect S3 buckets and CDN distributions.
What is the new behavior?
The workflow now resolves secrets using a combined channel-env key (e.g., freetown-prod), matching the logic used in deploy.yml. This ensures consistent and correct deployment targets across both workflows.
Breaking change
Does this PR introduce a breaking change?
No, this change is backward-compatible and improves correctness without altering existing interfaces or behavior for consumers.
Other useful information