feat: adding an edit icon to the existing photo to upload a new image#1180
Open
jaycenusa wants to merge 1 commit intoGreenstand:masterfrom
Open
feat: adding an edit icon to the existing photo to upload a new image#1180jaycenusa wants to merge 1 commit intoGreenstand:masterfrom
jaycenusa wants to merge 1 commit intoGreenstand:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a new edit icon to the image to upload a new photo via url or from local machine
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
What is the new behavior?
-> 1) if the user wants to upload a photo, the user can either provide an external URL or upload from local machine.
2) after clicking the edit icon, a dialog is prompted with two options, and click upload button to see the old and new images.
-> 3) After the user saved the changes, the previous photo will be replaced by the new image.
Breaking change
Does this PR introduce a breaking change?
No
Other useful information