added a variable mintLimit

[sebastiangaertner]

Since i have not run this as a dag yet this is the first attempt at this.

[sebastiangaertner]

not sure about this one though... syntax might be wrong

[dadiorchen]

We need to test it fully, I remember this syntax for variables:
f""" some {variable}"""

@CareyAltgilbers can you also help on this?

[sebastiangaertner]

@asarephilip there it is

[CareyAltgilbers]

@dadiorchen Yes, I'll be happy to take a look at it.

[CareyAltgilbers]

Hello,

It looks like on line 61 kwards is a typo and should be kwargs.

In the SQL statement on line 116 we should be able to change LIMIT .format(mintLimit) to Limit {} and then on line 117 change that to """.format(entityId, mintLimit))

That gives us two unnamed variables in this SQL statement, one on line 110 in a function call and another in line 116.

I ran the code in a test script and did not get any syntax errors, if you have some test data I can use for the entityId and mintLimit I would run the test script again.

cursor.execute("""
select id, uuid, token_id from trees
where
planter_id IN (
select id from planter
where
organization_id IN (
select entity_id from getEntityRelationshipChildren({})
)
)
AND active = true
AND approved = true
AND token_id IS NULL
LIMIT {}
""".format(entityId, mintLimit))

[sebastiangaertner]

changed it. Should be fine now. see new change request

[asarephilip]

I don't know the busines logic behind this but I will recommend setting a default minLimit rather than exiting the job when minLimit is None.

[sebastiangaertner]

business logic works better with a limit every time. that is fine

[sebastiangaertner]

@CareyAltgilbers this should be ok now or?

[CareyAltgilbers]

Those updates look good.