fix: resolve CORS misconfiguration blocking test-admin /verify endpoint#393
Open
arnoldcastro5000 wants to merge 3 commits intoGreenstand:mainfrom
Open
fix: resolve CORS misconfiguration blocking test-admin /verify endpoint#393arnoldcastro5000 wants to merge 3 commits intoGreenstand:mainfrom
arnoldcastro5000 wants to merge 3 commits intoGreenstand:mainfrom
Conversation
fix: add mapping.yaml to test overlay kustomization
fix: correct ambassador cors schema double-nesting in test mapping
fix: add namespace webmap to match base resource for kustomize patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1191
Root Cause
mapping.yamlinoverlays/test/was not referenced inkustomization.yaml,meaning the Ambassador CORS configuration was never applied to the test environment.
Additionally, the mapping had an incorrect double-nested
cors.corsschema whichwould have silently failed even if applied.
Changes
kustomization.yaml: addedmapping.yamltopatchesStrategicMergemapping.yaml: corrected Ambassador v2 CORS schema (removed doublecorsnesting)Verification
dev-admin.treetracker.org/verifyworks correctly (dev mapping is applied)test-admin.treetracker.org/verifyreturns CORS error — confirmed via browserdev tools:
No 'Access-Control-Allow-Origin' header present