Conversation
…otection Signed-off-by: Dennis Zhuang <[email protected]>
Signed-off-by: Dennis Zhuang <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds DNS rebinding protection and CORS configuration support for HTTP-based MCP transports (SSE and streamable-http). The implementation introduces two new configuration parameters that allow users to control security settings for their server deployments, with protection disabled by default for backward compatibility.
- Adds
allowed_hostsparameter to enable DNS rebinding protection with configurable host whitelist - Adds
allowed_originsparameter to configure CORS allowed origins (only effective when DNS rebinding protection is enabled) - Version bump from 0.4.1 to 0.4.2
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/greptimedb_mcp_server/config.py | Adds allowed_hosts and allowed_origins fields to Config dataclass with CLI and environment variable parsing logic |
| src/greptimedb_mcp_server/server.py | Implements DNS rebinding protection configuration using TransportSecuritySettings based on the new config parameters |
| tests/test_server.py | Updates test fixture to include empty lists for new allowed_hosts and allowed_origins parameters |
| README.md | Documents the DNS rebinding protection feature with usage examples for CLI arguments and environment variables |
| pyproject.toml | Bumps version from 0.4.1 to 0.4.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Dennis Zhuang <[email protected]>
sunng87
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See modelcontextprotocol/python-sdk#1798
allowed_hoststo enable DNS rebinding protection.allowed_originsto set allowed origins for CORS (for sse/streamable-http), only works whenallowed_hostsis set.