Merged
Conversation
Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables cross-platform CI testing by running the workflow on both Ubuntu and Windows, and adds explicit UTF-8 encoding to file operations to ensure consistent behavior across operating systems.
Changes:
- Modified GitHub Actions workflow to run on a matrix of operating systems (Ubuntu and Windows)
- Added explicit UTF-8 encoding to file open operations in the templates loader
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/python-app.yml | Updated to run CI on both Ubuntu and Windows using a matrix strategy |
| src/greptimedb_mcp_server/utils.py | Added UTF-8 encoding specification to file operations for cross-platform compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sunng87
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title said.