Skip to content

Conversation

@sunng87
Copy link
Member

@sunng87 sunng87 commented Feb 2, 2026

this patch update dryrun pipeline tool to work with inline pipeline without saving it. This is good for validating pipeline.

@gemini-code-assist
Copy link

Summary of Changes

Hello @sunng87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the pipeline dry run functionality, allowing users to validate pipeline configurations on the fly without the prerequisite of saving them. This change greatly improves the development workflow by providing immediate feedback on pipeline logic. The update includes a more flexible API for the dry run tool, comprehensive input validation, and clear documentation to guide users through the new capabilities.

Highlights

  • Inline Pipeline Dry Run: The dryrun_pipeline tool now supports testing pipeline configurations provided directly as inline YAML, removing the need to save them to the database first. This is ideal for quick validation.
  • Enhanced dryrun_pipeline Parameters: The dryrun_pipeline function has been updated to accept either an inline pipeline (YAML string) or a pipeline_name (for saved pipelines), but not both. A new data_type parameter has also been added to specify the content type of the test data.
  • Robust Input Validation: New validation checks are implemented in dryrun_pipeline to ensure that the data parameter is provided, and that exactly one of pipeline or pipeline_name is specified, preventing common usage errors.
  • Updated Documentation and Examples: The pipeline_creator template documentation has been revised to include clear examples and troubleshooting tips for using the dryrun_pipeline tool with both inline and saved pipelines, including details on data formats and the new parameters.
  • Comprehensive Test Coverage: Unit tests for dryrun_pipeline have been significantly expanded to cover the new inline pipeline functionality, the data_type parameter, and all new validation rules, ensuring the robustness of the changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the dryrun_pipeline tool by allowing inline pipeline configurations to be tested without needing to save them first. This is a valuable feature for validating pipeline logic. The changes are well-implemented, including updates to the dryrun_pipeline function, comprehensive validation logic, updated documentation with clear examples, and thorough unit tests covering the new functionality. The code quality is high, and I have one suggestion to make the validation logic even more concise and clear.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor

@sunng87 There are test failures.

@sunng87 sunng87 merged commit ef30f5f into main Feb 2, 2026
2 checks passed
@sunng87 sunng87 deleted the feature/dryrun-pipeline-inline-support branch February 2, 2026 12:34
@sunng87
Copy link
Member Author

sunng87 commented Feb 2, 2026

@killme2008 can we push a release for this?

@sunng87
Copy link
Member Author

sunng87 commented Feb 2, 2026

Let me create a tag for this.

@killme2008
Copy link
Contributor

killme2008 commented Feb 2, 2026

Let me create a tag for this.

Don't forget to bump the version before creating tag @sunng87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants