-
Notifications
You must be signed in to change notification settings - Fork 12
feat: allow inline pipeline in dryrun tool #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sunng87, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the pipeline dry run functionality, allowing users to validate pipeline configurations on the fly without the prerequisite of saving them. This change greatly improves the development workflow by providing immediate feedback on pipeline logic. The update includes a more flexible API for the dry run tool, comprehensive input validation, and clear documentation to guide users through the new capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the dryrun_pipeline tool by allowing inline pipeline configurations to be tested without needing to save them first. This is a valuable feature for validating pipeline logic. The changes are well-implemented, including updates to the dryrun_pipeline function, comprehensive validation logic, updated documentation with clear examples, and thorough unit tests covering the new functionality. The code quality is high, and I have one suggestion to make the validation logic even more concise and clear.
killme2008
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@sunng87 There are test failures. |
|
@killme2008 can we push a release for this? |
|
Let me create a tag for this. |
Don't forget to bump the version before creating tag @sunng87 |
this patch update dryrun pipeline tool to work with inline pipeline without saving it. This is good for validating pipeline.