fix[next]: Reuse parameters in direct fo calls#2375
Merged
Conversation
SF-N
marked this pull request as ready for review
November 6, 2025 16:08
tehrengruber
approved these changes
Nov 6, 2025
tehrengruber
requested changes
Nov 6, 2025
tehrengruber
left a comment
tehrengruber
left a comment
Contributor
There was a problem hiding this comment.
Issues in dace still need to be resolved.
Contributor
I opened a PR with the dace fix: #2382 |
tehrengruber
added a commit
to tehrengruber/gt4py
that referenced
this pull request
Nov 10, 2025
tehrengruber
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the parameter names in programs implicitly generated on a direct field operator call where of the form
__sym<uid>and thus different to the names specified in the field operator definition. This breaks when used in combination with static parameters on field operators (see enabled in #2368). The replacement works by replacing all refs to arguments by their static value. For direct field operator calls this refs are now named the same as in their definition.