Skip to content

bug[next]: Support for field operators returning K-only fields #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tehrengruber wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

bug[next]: Support for field operators returning K-only fields #2403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/gt4py/next/program_processors/codegens/gtfn/itir_to_gtfn_ir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,15 @@ def visit_FunCall(self, node: itir.FunCall) -> itir.FunCall:
assert isinstance(node.args[0], itir.FunCall)
first_axis_literal = node.args[0].args[0]
assert isinstance(first_axis_literal, itir.AxisLiteral)
if first_axis_literal.kind == itir.DimensionKind.VERTICAL:
assert len(node.args) == 2
assert isinstance(node.args[1], itir.FunCall)
assert isinstance(node.args[1].args[0], itir.AxisLiteral)
assert node.args[1].args[0].kind == itir.DimensionKind.HORIZONTAL
return itir.FunCall(fun=node.fun, args=[node.args[1], node.args[0]])
if len(node.args) <= 2:
if len(node.args) == 2 and first_axis_literal.kind == itir.DimensionKind.VERTICAL:
assert isinstance(node.args[1], itir.FunCall)
assert isinstance(node.args[1].args[0], itir.AxisLiteral)
assert node.args[1].args[0].kind == itir.DimensionKind.HORIZONTAL
return itir.FunCall(fun=node.fun, args=[node.args[1], node.args[0]])
return node
else:
raise NotImplementedError("Only up to two dimensional domains are supported.")
return node

@classmethod
Expand Down
8 changes: 8 additions & 0 deletions tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@ def testee(a: cases.IJKField) -> cases.IJKField:
cases.verify_with_default_data(cartesian_case, testee, ref=lambda a: a)


def test_copy_vertical(unstructured_case_3d):
@gtx.field_operator
def testee(a: cases.KField) -> cases.KField:
return a

cases.verify_with_default_data(unstructured_case_3d, testee, ref=lambda a: a)


@pytest.mark.uses_tuple_returns
def test_multicopy(cartesian_case):
@gtx.field_operator
Expand Down
Loading