Fix inner class access flags - #20
Merged
piazzesiNiccolo-GS merged 1 commit intoJan 30, 2026
Merged
Conversation
mrjameshamilton
force-pushed
the
jhamilton/fix-inner-class-flags
branch
from
January 29, 2026 18:22
c2a4699 to
4bb4087
Compare
mrjameshamilton
force-pushed
the
jhamilton/fix-inner-class-flags
branch
from
January 30, 2026 10:43
4bb4087 to
356be62
Compare
|
Thanks for the repro sample, verified it fixes it 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inner class access flags are currently parsed using the
expectClassAccessFlagsmethod which parses the class access flags. The set of access flags allowed on the inner class is smaller than the class access flags (see https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.7.6-300-D.2-5).In particular, the
ACC_SUPERshould not appear. JVMs appear to ignore this but stricter tools like ASM'sCheckClassAdapterfail as the flags are invalid.The error can be reproduced in the following small sample program that creates a Inner class file using the current ProGuard assembler release (1.0.0) and then tries to use the
CheckClassAdapterfrom ASM on this class:inner-class-validator.zip