Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#30 add recipe default option to settings #31

Merged

Conversation

B-Hartmann
Copy link
Contributor

This PR aims to close #30. It adds a new entry to the preferences to set the default recipe.
I updated the gui accordingly, populate the drowdown menu with the list of available recipes and make sure the value from the settings is loaded when the program starts.

What do you think?

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.54%. Comparing base (163c1cd) to head (b1e29ee).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
mpl_data_cast/gui/preferences.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   56.85%   56.54%   -0.31%     
==========================================
  Files          19       19              
  Lines         897     1031     +134     
==========================================
+ Hits          510      583      +73     
- Misses        387      448      +61     
Flag Coverage Δ
56.54% <20.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@B-Hartmann
Copy link
Contributor Author

@paulmueller What do you think about this PR?

Copy link
Member

@paulmueller paulmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few minor changes 👍

mpl_data_cast/gui/main.py Outdated Show resolved Hide resolved
mpl_data_cast/gui/preferences.py Outdated Show resolved Hide resolved
mpl_data_cast/gui/preferences.py Outdated Show resolved Hide resolved
@paulmueller paulmueller merged commit ec362ca into GuckLab:main Oct 15, 2024
3 checks passed
@B-Hartmann B-Hartmann deleted the #30_add_recipe_default_option_to_settings branch October 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI: Implement default recipe setting in preferences
3 participants